Fix for hard-coded audio testcall in audio config

Vadim Lebedev vadim at mbdsys.com
Mon Aug 25 10:35:11 CEST 2008


Applied

Ralf Schlatterbeck wrote:
> This is a hand-edited changeset, I've removed our patch for config.xml
> that sets the sip.testcall.audio to something kvats-specific.
> Anyway, I'm sure you don't want "333" there as a hard-coded string...
>
> # HG changeset patch
> # User Ralf Schlatterbeck <rsc at runtux.com>
> # Date 1219436828 -7200
> # Node ID f5e7d49185a9539691156764560c452b976cf4e5
> # Parent  1ba35cb1480eecb9edc8a8f1dcf9fdfddb730260
> Use getSipAudioTestCall (sip.testcall.audio in advanced config) from
> config.xml instead of using a hard-coded test-call number "333" for the
> "Make a test call" button in Tools/Configuration/Audio
>
> diff -r 1ba35cb1480e -r f5e7d49185a9 wengophone/src/presentation/qt/config/QtAudioSettings.cpp
> --- a/wengophone/src/presentation/qt/config/QtAudioSettings.cpp	Fri Aug 22 12:00:05 2008 +0200
> +++ b/wengophone/src/presentation/qt/config/QtAudioSettings.cpp	Fri Aug 22 22:27:08 2008 +0200
> @@ -41,8 +41,6 @@
>  
>  #include <QtGui/QtGui>
>  
> -static const char * AUDIO_TEST_CALL = "333";
> -
>  static AudioDevice getAudioDeviceFromComboBox(QComboBox* comboBox, const std::list<AudioDevice> deviceList) {
>  	std::string concatString = comboBox->itemData(comboBox->currentIndex()).toString().toStdString();
>  	for (std::list<AudioDevice>::const_iterator it = deviceList.begin();
> @@ -260,7 +258,9 @@ void QtAudioSettings::makeTestCallClicke
>  void QtAudioSettings::makeTestCallClicked() {
>  	CUserProfile * cUserProfile = _cWengoPhone.getCUserProfileHandler().getCUserProfile();
>  	if ((cUserProfile) && (cUserProfile->getUserProfile().getActivePhoneLine())) {
> -		cUserProfile->getUserProfile().getActivePhoneLine()->makeCall(AUDIO_TEST_CALL);
> +                Config & config = ConfigManager::getInstance().getCurrentConfig();
> +                std::string testnumber = config.getSipAudioTestCall ();
> +		cUserProfile->getUserProfile().getActivePhoneLine()->makeCall(testnumber);
>  		QtWengoPhone* qWengoPhone = static_cast<QtWengoPhone*>(_cWengoPhone.getPresentation());
>  		qWengoPhone->getWidget()->raise();
>  	}
>   



More information about the QuteCom-dev mailing list